Generate new thumbnail in startup scan if missing
Submitted by Jim Nelson
Assigned to cli..@..ba.org
Link to original bug (#716973)
Description
---- Reported by jim@yorba.org 2010-11-30 18:40:00 -0800 ----
Original Redmine bug id: 2889
Original URL: http://redmine.yorba.org/issues/2889
Searchable id: yorba-bug-2889
Original author: Jim Nelson
Original description:
We've seen some reports of thumbnail files not being written to disk after import (see #2200 (closed) and https://bugs.launchpad.net/ubuntu/source/shotwell/bug/6 82118 ) While these bugs should be resolved as well, one safety mechanism we could consider is validating the thumbnail file exists during the startup scan and regenerating if not present.
Related issues:
- related to shotwell - 2200: photos left without thumbnails if user exits Shotwell dur... (Open)
- related to shotwell - 6152: video thumbnails are not recreated if missing (Fixed)
- related to shotwell - 6203: When regenerating thumbnails, display busy or clock icon ... (Open)
- related to shotwell - 6040: Shotwell has problems after deleting thumbnails on Disk (Fixed)
- related to shotwell - 5910: Regenerate Thumbnails (Duplicate)
- duplicated by shotwell - 5710: Update photo thumbnails (Duplicate) follows shotwell - Task #421 (closed): store files in XDG-recommended directories (Fixed)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Priority set to High
Comment 2
Updated by Adam Dingle over 2 years ago
- Target version set to 0.11
I think this could reasonably be either automatic or manual, but users should have some way to regenerate missing thumbnails.
Comment 3
Updated by Adam Dingle over 2 years ago
-
Target version deleted (
<strike>
_0.11_</strike>
)
Comment 4
Updated by Jim Nelson about 2 years ago
- Description updated (diff)
Comment 5
Updated by Adam Dingle about 2 years ago
- Description updated (diff)
- Target version set to 0.12
We've had many requests for this. Marking for consideration for 0.12.
Comment 6
Updated by rv - about 2 years ago
Hi,
I don't think a big scan at every start-up is necessary. It would be more efficient (and less disk I/O) to only generate missing thumbnails when they are needed (ie when shotwell needs to display them), though it may take longer to display in this case.
Comment 7
Updated by Lucas Beeler about 2 years ago
- Assignee set to Clinton Rogers
Comment 8
Updated by Adam Dingle almost 2 years ago
-
Assignee deleted (
<strike>
_Clinton Rogers_</strike>
)
Let's hold off on this until we prioritize features for 0.12, hopefully soon.
Comment 9
Updated by Adam Dingle almost 2 years ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Comment 10
Updated by Cameron Braid over 1 year ago
For people who want a workaround to re-generate thumbnails, there's a good script that uses imagemagic
https://bitbucket.org/reece/reece-base/src/tip/bin/shotwell-regenerate- thumbnails
Cheers
Cameron
Comment 11
Updated by Jim Nelson over 1 year ago
Cameron,
Just eyeballing your script, I don't think this will completely work. This produces thumbnails directly from the master files. However, if the user has made any transformations to any of the photos (crop, color enhancement, etc.), that won't be reflected in the generated thumbnails. Those transformations are stored in the database and applied at runtime.
Comment 12
Updated by Thomas Novin over 1 year ago
This would be nice! I use Shotwell with multiple computers sharing the same db. But sharing the thumbnails will make it too slow.
The thumbnails is then a issue since they only exist on the machine that imported the photos, not the others.
Comment 13
Updated by Peter Baldwin over 1 year ago
I restored my photos from backup after my SSD failed, but I only saved the photos and db and now all my thumbnails are blank (except for videos)
Comment 14
Updated by Adam Dingle over 1 year ago
- Target version set to 0.13
This limitation has affected numerous users. Would be nice to improve the situation for 0.13.
Comment 15
Updated by rv - over 1 year ago
I still highly prefer to manually launch a "refresh selected thumbnails" when really needed and not an auto-feature at each start (more generally and ideally, I prefer manual choices instead of auto-updates at each start of shotwell)
Comment 16
Updated by Lucas Beeler over 1 year ago
- Assignee set to Clinton Rogers
Now that we've implemented #421 (closed), we must regenerate thumbnails because the XDG specification allows the user to clear his or her cache directory at any time.
Comment 17
Updated by Thomas Novin over 1 year ago
To not make the Shotwell startup time longer than it already is this should be a background process (configurable to be automatic or not perhaps). Shotwell already takes ~ 2 minutes to start on my system which is far more than what's acceptable.
Comment 18
Updated by Clinton Rogers over 1 year ago
- Status changed from Open to 5
- % Done changed from 0 to 100
- Resolution set to fixed
Extreme care was taken to not negatively affect startup times; the initial check whether the thumbnail is missing is simply an if-test to see whether a particular pixbuf is null or not, which isn't computationally expensive, and thumbnails whose pixbufs do turn out to be null are remade entirely in background threads.
Comment 19
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:48 UTC ---
This bug was previously known as bug 2889 at http://redmine.yorba.org/show_bug.cgi?id=2889
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED