shotwell svn crashes on video import
Submitted by an unknown user
Assigned to Eric Gregory
Link to original bug (#716972)
Description
---- Reported by shotwell-maint@gnome.bugs 2010-11-30 23:26:00 -0800 ----
Original Redmine bug id: 2890
Original URL: http://redmine.yorba.org/issues/2890
Searchable id: yorba-bug-2890
Original author: Norbert Preining
Original description:
Hi all,
I am running regular builds of the svn source to debian packages, and with the latest version svn rev 2401 I get a crash on import of a video:
ERROR:VideoMetadata.vala:221:quick_time_atom_next_atom: assertion failed: (self->priv->section_size >= self->priv->section_offset)
Aborted
Please let me know what I can do to track that down. Thanks
Norbert
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Adam Dingle almost 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Eric Gregory
- Priority set to Urgent
Comment 2
Updated by Jim Nelson almost 3 years ago
Eric -- this assertion was added by me. It indicates there is a situation where section_size is larger than section_offset. If that situation is due to a logic error, we should fix the bug. If that situation is due to bad data in the file (or is simply a legitimate situation), we should treat it as an error case and fail gracefully. We don't want to be doing unsigned subtraction on those two values in this situation, however.
Comment 3
Updated by Norbert Preining almost 3 years ago
Hi Jim, hi Eric,
the video (or the videos) was made with a Panasonic Lumix, one of it (50M) is available here:
http://www.logic.at/people/preining/00002.%(=caps)MTS%
(Forbidden City entrance)
shotwell crashed with:
[h264 @ 0x77c0000] sps_id out of range
[h264 @ 0x77c0000] non-existing SPS 32 referenced in buffering period
[h264 @ 0x77c0000] non-existing PPS referenced
**
ERROR:VideoMetadata.vala:221:quick_time_atom_next_atom: assertion failed: (self->priv->section_size >= self->priv->section_offset)
Aborted
where the upper part ([h264…]) was even colored in red.
When playing the video with mplayer I see:
TS file format detected.
%(=caps)VIDEO% %(=caps)H264% %(=caps)AUDIO% %(=caps)A52% %(=caps)SUB% Teletext(pid=4608) %(=caps)PROGRAM% N. 1
%(=caps)FPS% seems to be: 59.940060
…
Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
Selected video codec: [ffh264] vfm: ffmpeg (FFmpeg H.264)
================
================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
%(=caps)AUDIO%: 48000 Hz, 2 ch, s16le, 192.0 kbit/12.50% (ratio: 24000->192000)
Selected audio codec: [ffac3] afm: ffmpeg (FFmpeg AC-3)
==================
AO: [alsa] 48000Hz 2ch s16le (2 bytes per sample)
Starting playback…
Movie-Aspect is 1.78:1 – prescaling to correct movie aspect.
VO: [xv] 1280×720 => 1280×720 Planar YV12
A: 28.2 V: 28.4 A-V: -0.150 ct:-13.629 824/824 84% 3% 1.0% 6 0
Hope that helps, please let me know when I can delete the video from the web space, thanks.
All the best
Norbert
Comment 4
Updated by Eric Gregory almost 3 years ago
Hi Norbert,
I grabbed the file off your site and was able to replicate the bug. You're free to remove the file from your website.
Thank you for your help!
Comment 5
Updated by Norbert Preining almost 3 years ago
Thanks, I will continue give my svn builds a good testing …
Thanks for your great work
Norbert
Comment 6
Updated by Eric Gregory almost 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
This turned out to be a big in QuickTime video detection. The video was being detected as QuickTime, even though it's not. This threw off the parser.
Fixed in r2407
Comment 7
Updated by Norbert Preining almost 3 years ago
Hi everyone,
I confirm that with svn2413 I can import the videos without problem, although I get two of my four videos without thumbnail, the warning spit out on the console:
[h264 @ 0×883e140] sps_id out of range
[h264 @ 0×883e140] non-existing %(=caps)SPS% 32 referenced in buffering period
[h264 @ 0×883e140] non-existing %(=caps)PPS% referenced
[h264 @ 0×883e140] sps_id out of range
[h264 @ 0×883e140] non-existing %(=caps)SPS% 32 referenced in buffering period
[h264 @ 0×883e140] non-existing %(=caps)PPS% referenced
[h264 @ 0×7f0a8c1d9b40] sps_id out of range
[h264 @ 0×7f0a8c1d9b40] non-existing %(=caps)SPS% 32 referenced in buffering period
[h264 @ 0×7f0a8c1d9b40] non-existing %(=caps)PPS% referenced
Furthermore, the Makefile needs a fix for missing icons/16×16 and 24×24 direcories:
--- shotwell-0.7.2svn2413.orig/Makefile 2010-12-03 17:17:33.000000000 0900
++ shotwell-0.7.2svn2413/Makefile 2010-12-03 17:16:33.000000000 +0900
@@ -488,7 +488,9 @@
$(INSTALL_DATA) icons/* $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/shotwell/icons
mkdir -p $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor/scalable/apps
$(INSTALL_DATA) icons/shotwell.svg $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor/scalable/apps
+ mkdir -p $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor/16×16/apps
$(INSTALL_DATA) icons/shotwell-16.svg $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor/16×16/apps/shotwell.svg
+ mkdir -p $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor/24×24/apps
$(INSTALL_DATA) icons/shotwell-24.svg $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor/24×24/apps/shotwell.svg
ifndef DISABLE_ICON_UPDATE
-gtk-update-icon-cache -t -f $(%(=caps)DESTDIR%)$(%(=caps)PREFIX%)/share/icons/hicolor || :
Thanks and all the best
Norbert
Comment 8
Updated by Adam Dingle almost 3 years ago
Norbert,
thanks for the Makefile fix; I've committed it to trunk.
Does Nautilus show thumbnails for the two videos you mentioned which have no thumbnails in Shotwell? If so then this is a Shotwell bug, so could you open a new ticket for that and post the videos somewhere where we can retrieve them? Thanks!
Comment 9
Updated by Norbert Preining almost 3 years ago
Replying to [comment:9 adam]:
thanks for the Makefile fix; I've committed it to trunk.
Welcome.
Does Nautilus show thumbnails for the two videos you mentioned which have no thumbnails in Shotwell? If so then this is a Shotwell bug, so could you open a new ticket for that and post the videos somewhere where we can retrieve them? Thanks!
Nautilus did show thumbnails, so I removed the videos and reimported them, now there are thumbnails. Don't ask me. Since I cannot reproduce it let us forget that matter.
Thanks
Norbert
Comment 10
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:48 UTC ---
This bug was previously known as bug 2890 at http://redmine.yorba.org/show_bug.cgi?id=2890
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED