make selected items look like in other GNOME apps
Submitted by Adam Dingle
Link to original bug (#716971)
Description
---- Reported by adam@yorba.org 2010-12-01 08:47:00 -0800 ----
Original Redmine bug id: 2892
Original URL: http://redmine.yorba.org/issues/2892
Searchable id: yorba-bug-2892
Original author: Adam Dingle
Original description:
Filed at https://bugs.launchpad.net/bugs/683588 :
Most Gnome apps show selected items in a certain way, as shown in theattached screenshot by images taken from Evince and EOG. Shotwell'sselected items look completely different, though, which makes the applook alien in the Gnome desktop.
I think Shotwell would look better and fit more tightly if it were touse the same look as the rest of the apps.
We've discussed this before, though not for a few releases. We are interested in a common GNOME look and feel, so this may be worth reconsidering.
---- Additional Comments From shotwell-maint@gnome.bugs 2011-01-06 14:41:00 -0800 ----
History
Comment 1
Updated by Andrew - almost 3 years ago
Attached is a patch which removes all the custom colours from CheckBoardLayout.vala and Config.vala (except for the custom bg colour) and replaces them with colors from the user's GTK theme.
I have tested this with a variety of themes and they all look spot-on!
Attached is a screenshot of what Shotwell looks like with the patch applied, with the Ubuntu Radiance Theme
Comment 2
Updated by Andrew - almost 3 years ago
I just updated my patch, so that now colours update if the GTK Theme is changed.
This can now be merged into trunk.
Comment 3
Updated by Lucas Beeler almost 3 years ago
@ and471 -- all of us on the Shotwell team just got back from our Winter Holiday. But thank you so much for the patch! We'll review it over the next week or so.
Comment 4
Updated by Adam Dingle almost 3 years ago
and471,
thanks for the patch. This patch affects various colors in Shotwell – in some cases we like the color changes and in other cases we don't.
First the bad news:the patch changes the color of text displayed below photos (e.g. titles and tags) so that it is sometimes hard to read. Without your patch, Shotwell changes the text color on the fly as the user drags the background color slider in the Preferences dialog. When the background is dark, Shotwell displays text in a light color and vice versa, so the text is always easy to read. With your patch, the text color is always dark, so it's hard to read with Shotwell's default dark gray background.
Your patch also changes the color of the border which Shotwell displays around each photo. Again, without your patch Shotwell changes this color dynamically so that it's always clearly visible against the background color the user has chosen. WIth your patch, the border is always dark, which doesn't look as good against the default background as the existing white border does.
Now some better news. Your patch changes the selection color and we like the new selection color better, for some themes at least. In Ubuntu's default Ambiance theme, your patch makes the selection color a bold orange, which looks good and fits in nicely with the rest of the theme. In the default GNOME Clearlooks theme, your patch makes the selection color a neutral blue. Some members of our team like this, and others feel it's harder to see than Shotwell's current neon blue selection color.
We'd consider an updated version of the patch which changes the selection color only, though I think we'd want to have a discussion on the mailing list about how users feel about the selection color (particularly those who use Clearlooks) before committing to this change.
--- Bug imported by chaz@yorba.org 2013-11-25 21:48 UTC ---
This bug was previously known as bug 2892 at http://redmine.yorba.org/show_bug.cgi?id=2892 Imported an attachment (id=261862) Imported an attachment (id=261863)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Resolution: RESOLVED FIXED