Can't undo merge of two renamed events
Submitted by Eric Gregory
Assigned to Eric Gregory
Link to original bug (#716951)
Description
---- Reported by eric@yorba.org 2010-12-03 16:47:00 -0800 ----
Original Redmine bug id: 2914
Original URL: http://redmine.yorba.org/issues/2914
Searchable id: yorba-bug-2914
Original author: Eric Gregory
Original description:
Steps:
-
Go to Events view
-
Rename two events
-
Select both and hit merge
-
Try to undo
Note that step 4 fails.
(However it will NOT fail if we add a step 2.1 where we restart Shotwell.)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----
History
Comment 1
Updated by Eric Gregory almost 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Eric Gregory
Comment 2
Updated by Eric Gregory almost 3 years ago
- Subject changed from Can't undo merge of two named events to Can't undo merge of two renamed events
Comment 3
Updated by Eric Gregory almost 3 years ago
The issue is that when you rename an event, the rename command is placed on the undo stack. Then when you merge the two events, one of the events is destroyed -- and if the rename command is listening for the destroy signal on one of those events, it clears the undo stack.
Comment 4
Updated by Jim Nelson almost 3 years ago
Right -- this behavior is due to the fact that we don't want to deal with selectively removing Commands from the undo stack.
What we need to do is change RenameEventCommand from a SingleDataSourceCommand to a SimpleProxyableCommand. See RenameTagCommand for an example.
Comment 5
Updated by Eric Gregory almost 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Fixed as described in comment:5
r2467
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:48 UTC ---
This bug was previously known as bug 2914 at http://redmine.yorba.org/show_bug.cgi?id=2914
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED