replace commas in imported tags with a different separator
Submitted by Adam Dingle
Link to original bug (#716848)
Description
---- Reported by adam@yorba.org 2010-09-14 11:33:00 -0700 ----
Original Redmine bug id: 2557
Original URL: http://redmine.yorba.org/issues/2557
Searchable id: yorba-bug-2557
Original author: Adam Dingle
Original description:
Reported at https://bugs.launchpad.net/bugs/638321 :
This is a bug about the way Shotwell handles importing a batch of photos which have previously been managed by F-spot.
In F-spot there is no problem with having commas in the tag names, so a tag like Surname, Firstname is fine. When this tag is imported into Shotwell it keeps the tag as Surname, Firstname but as soon as you apply it to anything creates two new tags one called Surname and one called Firstname. This quickly starts to make a real mess of my tagging system where I have lots of people in the Surname, Firstname format.
If Shotwell finds commas in imported tags, I think it should simply replace them with a different character, e.g. '_'.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:46:00 -0700 ----
History
Comment 1
Updated by Bruno Girin about 3 years ago
Replacing all commas with a different character during the import should not be too difficult. Notifying the user will be a tad trickier though.
However, it may just be a display issue. I just tried this from trunk:
- add a tag with no comma to a photo: “tag1â€
- right-click on the tag name in the left hand pane to rename it to “tag1, tag2â€
- the tag is now shown as “tag1†in the left hand pane but under the photo it is shown as “tag1, tag2â€
- right click on the photo and you have a menu entry that says 'Remove Tag “tag1, tag2†From Photo'
- restart Shotwell and it shows the tag as “tag1, tag2†in the left-hand pane
- assigning a photo to an existing tag seems to work whether there is a comma or not
So it looks like Shotwell properly stores and retrieves tags that contain a comma but doesn't display them properly in the left-hand pane until it is restarted.
Comment 2
Updated by Marcel Stimberg over 2 years ago
- Keywords set to tags
I'm wondering whether shotwell should not just give up the comma as a separator. This would ease cooperation with other programs. I think a sensible way would be to just use spaces for separating tags in the add/modify tag dialog (most tags are one word anyway). If you want to have a tag containing spaces, you can enclose it in quotation marks. I think this technique is quite established in search and for example flickr uses it for tagging.
Comment 3
Updated by rv - about 2 years ago
- Description updated (diff)
And why not some other character as a separator like "/" or (better?) "|".
Comment 4
Updated by Adam Dingle about 2 years ago
- Target version set to 0.12
See also the discussion at
http://lists.yorba.org/pipermail/shotwell/2011-November/003358.html
Comment 5
Updated by Adam Dingle about 2 years ago
In that email discussion, Dougie Nisbet wrote:
Take the example tag of: Kretzschmaria deusta (Brittle Cinder, Charcoal
Fungus)
Select two images, press Ctrl-T, and start typying the tag. In my setup,
I am offered two choices;
Kretzschmaria
Kretzschmaria deusta (Brittle Cinder, Charcoal Fungus)
That's fine. That's what I expect and want, so I keep typing to get the
unique match, then select OK.
At this point (in my setup) something odd happens and, as I say, I've
only just spotted it, as on previous occasions I think I must have
assumed the tagging had worked correctly and just carried on. What
happens is that the tag is interpreted as two new tags:
Kretzschmaria deusta (Brittle Cinder
Charcoal Fungus)
so my guess is that the comma in the tag name was interpreted as a tag
delimiter in this situation. However I do have lots of images tagged
(correctly) with this tag, and my suspicion is that I renamed the tag at
some time and the images have been accurately updated.
The two 'new' tags appear as top-level tags.
Comment 6
Updated by Adam Dingle over 1 year ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Comment 7
Updated by Adam Dingle over 1 year ago
- Status changed from Open to 5
- Resolution set to wontfix
It seems that some people actually want tags to be able to contain commas, so I am no longer convinced that Shotwell should replace commas with another character. Marking this as wontfix.
Comment 8
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Invalid
--- Bug imported by chaz@yorba.org 2013-11-25 21:47 UTC ---
This bug was previously known as bug 2557 at http://redmine.yorba.org/show_bug.cgi?id=2557
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED INVALID