tag autocompletion fails with non-ASCII characters
Submitted by Adam Dingle
Assigned to Lucas Beeler
Link to original bug (#716799)
Description
---- Reported by adam@yorba.org 2010-09-28 08:46:00 -0700 ----
Original Redmine bug id: 2612
Original URL: http://redmine.yorba.org/issues/2612
Searchable id: yorba-bug-2612
Original author: Adam Dingle
Original description:
To see the problem:
Add the tag “scar†to a photo.
Select another photo, choose Tags->Add Tags, and type “â€. You should seen an autocompletion box showing the tag you previously added, but it won't appear.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Marcel Stimberg about 3 years ago
- Assignee changed from Anonymous to Marcel Stimberg
As I have implemented the tag autocompletion (and use a language that has Umlauts :-)) I'll take care of this.
Comment 2
Updated by Marcel Stimberg about 3 years ago
- Keywords set to tags autocompletion
The problem is that unicode provides two ways to represent composed character such as Ҡor Ҡ-- either as one character or as a composition of e.g. ""+"e". The patch below normalizes the strings that are compared in a consistent way using only the composed representation (i.e. Ҡis one character not two).
Comment 3
Updated by Jim Nelson about 3 years ago
- Resolution set to fixed
- % Done set to 100
Looks good. Committed!
Comment 4
Updated by Marcel Stimberg over 2 years ago
- Status changed from 5 to 4
-
Resolution deleted (
<strike>
_fixed_</strike>
) - % Done changed from 100 to 0
I am reopening this bug because a user reported a very related problem with Tags and Non-%(=caps)ASCII% characters: http://lists.yorba.org/pipermail/shotwell/2011-April/002107.html
As shown in his linked screencast if the first tag is for example “Clrinaâ€, the addition of additional tags by autocompletion leads to a removal of the comma. This again has to do with normalization.
I'll attach a patch that should fix the issue.
Comment 5
Updated by Adam Dingle over 2 years ago
- Status changed from 4 to Review
- Assignee changed from Marcel Stimberg to Lucas Beeler
- Target version set to 0.10
Marcel, thanks for investigating this and for your patch. Lucas, please review – thanks.
Comment 6
Updated by Lucas Beeler over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Comment 7
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:47 UTC ---
This bug was previously known as bug 2612 at http://redmine.yorba.org/show_bug.cgi?id=2612 Imported an attachment (id=261808) Imported an attachment (id=261809)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED