event photos appear pixellated
Submitted by Adam Dingle
Assigned to Lucas Beeler
Link to original bug (#716798)
Description
---- Reported by adam@yorba.org 2010-09-28 09:00:00 -0700 ----
Original Redmine bug id: 2613
Original URL: http://redmine.yorba.org/issues/2613
Searchable id: yorba-bug-2613
Original author: Adam Dingle
Original description:
I'm attaching two screenshots of Shotwell. The first shows the event view for August 2010, showing one key photo for each event. Look at the picture of the church, and notice how jagged the roof edges appear. The second screenshot shows the same picture in photos view, where the thumbnail size has been set to approximately the same size used in event view. In the second screenshot, the roof edges appear smooth. They should appear equally nice in event view.
I'll also attach the original photo (which is by Maciej Rumianowski, by the way).
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Eric Gregory almost 3 years ago
Note: possibly the same issue as ticket #1202 (closed)
Comment 2
Updated by Maxim - almost 3 years ago
I'm seeing this as well
Comment 3
Updated by Adam Dingle almost 3 years ago
- Target version set to 0.9
Comment 4
Updated by Adam Dingle over 2 years ago
-
Target version deleted (
<strike>
_0.9_</strike>
)
A bit late to look at this now; dropping from 0.9.
Comment 5
Updated by Valentín Barros over 2 years ago
The problem seems to be in Photo.get_preview_pixbuf, as it uses Gdk.InterpType.%(=caps)NEAREST% to scale the pixbuf. Using Gdk.InterpType.%(=caps)BILINEAR% the problem is gone.
But, please note this comment in MediaDataRepresentation.get_preview_pixbuf abstract method:
// A preview pixbuf is one that can be quickly generated and scaled as a preview. For media
// type that support transformations (i.e. photos) it is fully transformed.
//
// Note that an unscaled scaling is not considered a performance-killer for this method,
// although the quality of the pixbuf may be quite poor compared to the actual unscaled
// transformed pixbuf.
Maybe that poor appearance of the thumbnail is a desired feature… I think that if the photo thumbnails are scaled with Gdk.InterpType.%(=caps)BILINEAR%, maybe the same should apply to event thumbnails, I don't know.
I attach a patch to the bug.
Comment 6
Updated by Adam Dingle over 2 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Lucas Beeler
- Target version set to 0.10
Thanks for the patch. Lucas, can you review?
Comment 7
Updated by Lucas Beeler over 2 years ago
Patch reviewed. Ready to commit. Awaiting name of author to properly credit him/her in THANKS file.
Comment 8
Updated by Adam Dingle over 2 years ago
The author isValentn Barros (valentin at sanva.net).
Lucas, talk to me tomorrow and we'll set you up as a Trac administrator so you can look up Trac registration information directly.
Comment 9
Updated by Lucas Beeler over 2 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
Fixed in 942b7264
Comment 10
Updated by Lucas Beeler over 2 years ago
Unfortunately, fixing this does not fix #1202 (closed).
Comment 11
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:47 UTC ---
This bug was previously known as bug 2613 at http://redmine.yorba.org/show_bug.cgi?id=2613 Imported an attachment (id=261804) Imported an attachment (id=261805) Imported an attachment (id=261806) Imported an attachment (id=261807)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.10
Resolution: RESOLVED FIXED