rotate keys are bad for many kinds of keyboards
Submitted by Adam Dingle
Assigned to Eric Gregory
Link to original bug (#716737)
Description
---- Reported by adam@yorba.org 2010-10-18 09:41:00 -0700 ----
Original Redmine bug id: 2700
Original URL: http://redmine.yorba.org/issues/2700
Searchable id: yorba-bug-2700
Original author: Adam Dingle
Original description:
Reported at https://bugs.launchpad.net/ubuntu/source/shotwell/bug/662640 :
Shotwell uses the square bracket (" and ") keyboard shortcuts for rotating photos. This is fine for users of US/UK keyboards and other keyboards in which one is not required to use a modifier key to get the square brackets. However it is quite annoying for myself and others with different keyboard layouts. I for example have to use AltGr+8 and AltGr+9 to get them. Because I rarely use the square brackets, I cannot find them on the keyboard without looking. This means I rarely use them for rotation.
As an alternative I propose the Ctrl+R and Shift+Ctrl+R used by Eye of Gnome for example.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Adam Dingle about 3 years ago
I agree: let's return to Ctrl+R and Shift+Ctrl+R. (It's tempting to use Ctrl+Left and Ctrl+Right which are the rotation keys in Evince, but we can't use those since we'll use those keys to implement Nautilus-compatible disjoint selection; see#2320.)
Comment 2
Updated by Adam Dingle about 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Eric Gregory
Comment 3
Updated by Eric Gregory about 3 years ago
We've decided to change Crop to Ctrl-O to allow for this change.
Comment 4
Updated by Eric Gregory about 3 years ago
We've also decided to change View Ratings to Shift-Ctrl-A
Comment 5
Updated by Adam Dingle about 3 years ago
Eric,
I know you have a patch for this pending code review. I've thought about this more and now think we should continue to support ' and ' as alternate keyboard shortcuts for rotation: many users will be familiar with these shortcuts from Shotwell 0.7 and may be disappointed if they go away. So please revise the patch to include these – thanks! There are other places in Shotwell where we have alternate shortcuts for certain operations, e.g. the zoom in/out commands, so you might want to look at how those are implemented in the code.
Comment 6
Updated by Adam Dingle about 3 years ago
Oops – the wiki formatting messed up my last comment. I meant the left and right square bracket keys, of course.
Comment 7
Updated by Eric Gregory about 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done changed from 0 to 100
The affected keyboard commands are:
] or Ctrl-R: Rotate right
[ or Ctrl-Shift-R: Rotate left
Ctrl-A: View ratings
Ctrl-O: Crop (in editing mode)
Fixed in svn r2363
Comment 8
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:47 UTC ---
This bug was previously known as bug 2700 at http://redmine.yorba.org/show_bug.cgi?id=2700
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED