Check max Vala version at compile time
Submitted by Jim Nelson
Link to original bug (#716734)
Description
---- Reported by jim@yorba.org 2010-10-19 14:30:00 -0700 ----
Original Redmine bug id: 2705
Original URL: http://redmine.yorba.org/issues/2705
Searchable id: yorba-bug-2705
Original author: Jim Nelson
Original description:
Right now our build system only checks for a minimum Vala version. We should also check for a max version to warn users if they're too far ahead of the curve.
This should be coded in such a way that if the max version is not specified the check is not made (i.e. it works like today).
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by bl4sph3my - about 3 years ago
As long as shotwell use just one major version of vala, this could be the way to go. Also it solves the problem, that the wrong version of vala will be used, 'cause valac is linked to the wrong version.
Comment 2
Updated by Adam Dingle almost 3 years ago
Note attached patch from several weeks ago. Independently of that, Daniel van Gerpen dvg@jccnet.de sent an implementation which I'll also attach. Jim, could you review and select one of these implementations if appropriate?
Comment 3
Updated by Jim Nelson almost 3 years ago
I looked at the first diff a while back but somehow forgot to comment on it. I didn't feel it went about the problem the right way. Specifically, it relied on the installed compiler binary's filename. I was hoping to have something more programmatic.
The second patch from Daniel is closer to what I had in mind. There's a lot of duplicated code in minver and maxver. My thinking was to have a single script file that could do both (either accepting the range on the command-line or have a min/max mode via a command-line switch).
If we could combine minver and maxver into a single script, I think this would be good to go.
Comment 4
Updated by Adam Dingle almost 3 years ago
We could either do that, or just wait for 0.9. I'm hoping that we can move to waf in the 0.9 time frame, at which point the minver script will hopefully disappear completely.
Comment 5
Updated by Jim Nelson almost 3 years ago
- Status changed from Open to 5
- Resolution set to fixed
- % Done changed from 0 to 100
r2597
Comment 6
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:47 UTC ---
This bug was previously known as bug 2705 at http://redmine.yorba.org/show_bug.cgi?id=2705 Imported an attachment (id=261777) Imported an attachment (id=261778) Imported an attachment (id=261779)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED