rating photos is slow
Submitted by Adam Dingle
Link to original bug (#716559)
Description
---- Reported by adam@yorba.org 2010-08-18 10:07:00 -0700 ----
Original Redmine bug id: 2433
Original URL: http://redmine.yorba.org/issues/2433
Searchable id: yorba-bug-2433
Original author: Adam Dingle
Original description:
According to the ShotwellPerformanceTesting page, it takes 125 seconds to rate 1000 photos, but only 3 seconds to tag 11,000 photos. This means that rating a photo is at least 400 times slower than tagging a photo. We should investigate whether we can speed up the rating operation.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:37:00 -0700 ----
History
Comment 1
Updated by Jim Nelson over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
) - Tracker changed from Bug to Feature
I think there might be some easy wins here. I'm bumping up to release.
Comment 2
Updated by Jim Nelson over 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Jim Nelson
I've committed a small change which speeds things up a bit. Vera, can you retest and post the revised numbers?
Comment 3
Updated by Vera Yin over 3 years ago
Much faster now – 3.9 seconds for rating 1000 photos, 27.6 seconds for rating 11,000 photos. However, half of that time is after the Ratings dialog has claimed completion and gone away (only a silhouette remains) during which Shotwell is unresponsive.
Comment 4
Updated by Adam Dingle over 3 years ago
Jim will make a further change to batch the rating updates to improve responsiveness.
Comment 5
Updated by Jim Nelson over 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done set to 100
I've committed a change that will prevent the hang at the end of the ratings. It's not as fast as it used to be (but definitely faster).
We should leave this open and attack this in the future. There is a better solution, but I'm uncomfortable making it right before releasing 0.7.
Comment 6
Updated by Jim Nelson over 3 years ago
- Status changed from 5 to 4
-
Resolution deleted (
<strike>
_fixed_</strike>
) - % Done changed from 100 to 0
Whoops -- closed it by accident.
Comment 7
Updated by Adam Dingle over 3 years ago
- Priority set to High
Dropping to high; no further changes needed for 0.7.
Comment 8
Updated by Adam Dingle about 3 years ago
- Status changed from 4 to Review
- Assignee changed from Jim Nelson to Anonymous
Comment 9
Updated by Adam Dingle about 3 years ago
- Tracker changed from Feature to Bug
Comment 10
Updated by Adam Dingle almost 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
I think the current number on theShotwellPerformanceTestingis good enough for 0.8. Dropping to medium.
Comment 11
Updated by Jim Nelson 11 months ago
- Target version set to 0.14.0
Comment 12
Updated by Jim Nelson 11 months ago
- Category set to ux
Comment 13
Updated by Jim Nelson 11 months ago
- Category changed from ux to performance
Comment 14
Updated by Jim Nelson 10 months ago
- Target version changed from 0.14.0 to 0.15.0
Comment 15
Updated by Jim Nelson 6 months ago
-
Target version deleted (
<strike>
_0.15.0_</strike>
)
--- Bug imported by chaz@yorba.org 2013-11-25 21:46 UTC ---
This bug was previously known as bug 2433 at http://redmine.yorba.org/show_bug.cgi?id=2433
Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution