Accept odd EXIF date format
Submitted by an unknown user
Link to original bug (#716171)
Description
---- Reported by shotwell-maint@gnome.bugs 2010-05-17 15:17:00 -0700 ----
Original Redmine bug id: 1939
Original URL: http://redmine.yorba.org/issues/1939
Searchable id: yorba-bug-1939
Original author: Dominic Lloyd
Original description:
My camera, a Minolta DiMAGE E223, has an odd EXIF date format. It puts a colon between day and hour instead of a space, so all my photos go to 1969. Example: DateTime 2010:04:05:16:06:54 instead of 2010:04:05 16:06:54
Can Shotwell be modified to accept this format? It also appears in DateTimeOriginal and DateTimeDigitized. This is in Shotwell 0.5.0 in Ubuntu 10.04.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Bengt Thuree over 3 years ago
Can you attach a small photo from your camera with the odd EXIF date format
Comment 2
Updated by Adam Dingle over 3 years ago
- Priority set to High
We think this is a bug in your camera! :) Nevertheless this shouldn't be too hard to fix – no promises, but maybe we'll get the chance at some point. We'd happily accept a patch if you feel like helping out.
Comment 3
Updated by Dominic Lloyd over 3 years ago
I would like to help out, but I'm not sure how to get started. Can you point me in the right direction?
Comment 4
Updated by Jim Nelson over 3 years ago
Go here to see how to build Shotwell from trunk: http://yorba.org/shotwell/install/ You'll need Vala 0.8.0 (0.8.1 highly recommended) to build.
The timestamp decode code is in MetadataDateTime.from_exif_date_time, which is located in src/!PhotoMetadata.vala. I suspect when you see the code you'll have some ideas right away how to fix it.
Comment 5
Updated by Dominic Lloyd over 3 years ago
I downloaded the source by running $ svn co svn://svn.yorba.org/shotwell/trunk shotwell
patched it, compiled it, and tested it with photos from my camera and from other cameras. Now I'm ready to upload the patched file. Can you advise me on how to do that?
Comment 6
Updated by Jim Nelson over 3 years ago
Great! Do
svn diff > odd_exif.diff
and attach it to this ticket.
Comment 7
Updated by Dominic Lloyd over 3 years ago
Is there anything else I should do? Should I have set myself as the owner? Should I change the Action?
Comment 8
Updated by Jim Nelson over 3 years ago
- Status changed from Open to 5
- Resolution set to fixed
- % Done set to 100
No, that's fine -- I'm catching up with tickets today. I looked it over and it looks great, so I committed it. Thanks!
Comment 9
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:44 UTC ---
This bug was previously known as bug 1939 at http://redmine.yorba.org/show_bug.cgi?id=1939 Imported an attachment (id=261651) Imported an attachment (id=261652)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED