display critical errors in terminal window
Submitted by Adam Dingle
Link to original bug (#715981)
Description
---- Reported by adam@yorba.org 2010-03-10 15:34:00 -0800 ----
Original Redmine bug id: 1550
Original URL: http://redmine.yorba.org/issues/1550
Searchable id: yorba-bug-1550
Original author: Adam Dingle
Original description:
From Martin Olsson:
CRITICAL should be printed to the terminal by default
(giving better bug reports from people who are not that
familar with Shotwell and who don't bother learning about
SHOTWELL_X envars). Maybe WARNING as well but you seem to
be using that quite a lot for stuff which is not Shotwell bugs.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
Comment 2
Updated by Adam Dingle over 2 years ago
- Target version set to 0.10
- Priority set to High
Virtually every other GNOME application displays such errors in the terminal by default, so we should too.
Comment 3
Updated by Adam Dingle over 2 years ago
-
Target version deleted (
<strike>
_0.10_</strike>
)
Comment 4
Updated by Adam Dingle over 2 years ago
- Target version set to 0.11
Comment 5
Updated by Lucas Beeler over 2 years ago
-
Target version deleted (
<strike>
_0.11_</strike>
)
Comment 6
Updated by Adam Dingle over 1 year ago
- Description updated (diff)
- Target version set to 0.13
Comment 7
Updated by Adam Dingle over 1 year ago
See, for example, #4955 (closed).
Comment 8
Updated by Jonas Bushart over 1 year ago
- File 0001-Fixes-#1550-by-writing-log-messages-to-stderr-when-not-previous-done.patch added
Fixes #1550 (closed) by writing log messages to stderr when not previous done
log_file_stream gets only set if a file is used, then all messages will be
written in the file. If log_file_stream is null (means problem with
opening the file) the messages will be written to stdout and stderr
so no need to write them again to stderr.
To log other levels the if statement has to be copied to the other handlers just like with the critical one. Maybe also change stderr to stdout.
Comment 9
Updated by Adam Dingle over 1 year ago
- Status changed from Open to Review
Lucas, please review. Thanks!
Comment 10
Updated by Adam Dingle about 1 year ago
Even without this patch, critical errors generated inside GTK get written to the console (at least on Ubuntu Quantal) - that's why we can observe #5704, for example. But critical errors from inside Shotwell are written only to the log file.
Comment 11
Updated by Adam Dingle about 1 year ago
- Status changed from Review to 5
- Resolution set to fixed
Thanks for the patch, which looks pretty good. I've committed this with minor changes.
Comment 12
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:43 UTC ---
This bug was previously known as bug 1550 at http://redmine.yorba.org/show_bug.cgi?id=1550 Imported an attachment (id=261622)
Unknown Component Using default product and component set in Parameters Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Version: 0.13
Resolution: RESOLVED FIXED