music in slideshows
Submitted by Adam Dingle
Link to original bug (#715976)
Description
---- Reported by adam@yorba.org 2010-03-12 12:21:00 -0800 ----
Original Redmine bug id: 1557
Original URL: http://redmine.yorba.org/issues/1557
Searchable id: yorba-bug-1557
Original author: Adam Dingle
Original description:
music in slideshows
---- Additional Comments From shotwell-maint@gnome.bugs 2011-04-07 12:02:00 -0700 ----
History
Comment 1
Updated by Sriram Ganesan over 2 years ago
Please ignore the firstpatch.
Attached patches of two files. Slideshowpage.vala and AppWindowpage.vala.
Additionaly the path of the music file to played can be set in Resources.
As an Example:
public const string=“file:///home/Music_file1.mp3â€;
Comment 2
Updated by Lucas Beeler over 2 years ago
Comments by Adam on the submitted patch:
I think what we'd like is pretty straightforward. The slideshow settings dialog should have a checkbox called “Play music during slideshow†and an associated file chooser button. If the checkbox is checked, the file chooser will let the user choose a music file to play. Optionally, it might be nice if there were also a play/pause button which the user could use to preview the music in that dialog before starting the actual slideshow.
Comments by Lucas on the submitted patch:
(i) User Interface Changes
In addition to all of the things that Adam mentioned above, I'd add
one more requirement: we need a volume slider, either in the Settings
dialog or possibly, when music playback is enabled, on the slideshow
tool palette itself. The reason I ask for this is two-fold. First, all
GNOME media applications provide an in-application volume control in
addition to the system volume control. For example, in Totem it
appears in the lower-right-hand corner of the main pane. Second, since
Shotwell slideshows run full-screen, access to the system volume
control on the GNOME panels isn't possible. So, in the present state
of affairs, you can't adjust the playback volume during a slideshow at
all.
I run Fedora, which by default doesn't come with an installed CODEC
for MP3 audio. So when I set my DEFAULT_SONG_URI to point to an MP3
file on my hard disk, I heard no audio played back and I got no error
message telling me why. GStreamer has facilities for dealing with this
through gstreamer-codec-install and gnome-codec-install. Take a look
at how they work. They should pop up a dialog box that explains the
name of missing codec and tries to use the system package manager to
find it.
(ii) Code Stuff
At AppWindow.vala:159, you've got the following lines:
SlideshowPage? page = get_current_page() as SlideshowPage;
if (page is SlideshowPage) {
page.on_exit_slideshow();
}
Note that the runtime type check (page is SlideshowPage) is
unnecessary, since the “as†operator returns a null reference if page
isn't a SlideshowPage. So your check on the next line (page is
SlideshowPage) really only needs to be (page != null). While it
doesn't matter so much here, you should know that GObject RTTI is
really, really, slow. So use it sparingly. If you can make one RTTI
call instead of two, all the better.
At SlideshowPage.vala:229 you've got two blank lines in a row. In
general, for Yorba projects, we use only one line of whitespace. Make
sure you read over the Yorba Coding Conventions here
http://trac.yorba.org/wiki/CodingConventions and ensure that any patch
you submit conforms to them.
--- Bug imported by chaz@yorba.org 2013-11-25 21:43 UTC ---
This bug was previously known as bug 1557 at http://redmine.yorba.org/show_bug.cgi?id=1557 Imported an attachment (id=261619) Imported an attachment (id=261620) Imported an attachment (id=261621)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Resolution: RESOLVED DUPLICATE