Update Gtk.Action, not Gtk.Widget, in UI code
Submitted by Jim Nelson
Assigned to Jim Nelson
Link to original bug (#715974)
Description
---- Reported by jim@yorba.org 2010-03-12 16:48:00 -0800 ----
Original Redmine bug id: 1560
Original URL: http://redmine.yorba.org/issues/1560
Searchable id: yorba-bug-1560
Original author: Jim Nelson
Original description:
When I started coding Shotwell -- young and innocent in the ways of the world -- I updated UI elements by accessing their widget and modifying them directly. In the case of an operation that has a menu item, a content menu item, and a toolbar item, this is nasty and error-prone. This is not how things should be in GTK Land.
By tearing all that out and replacing it with code that updates the widgets' action, we can centralize the UI logic on each page. Some of this logic is duplicated in pages because of common menu items (undo/redo, quit, about, etc.) This can be centralized in the main window object (where these menu items reside) by the same strategy.
This will reduce line count, reduce bugs, and make it far easier to create new pages in the future.
---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:40:00 -0700 ----
History
Comment 1
Updated by Adam Dingle over 3 years ago
-
Priority deleted (
<strike>
_High_</strike>
)
For now, we've decided to make this change incrementally from now on as we touch various parts of the code. I'll keep this ticket open in case we do want to make a monolithic sweep to make this change everywhere at some point. Dropping to medium.
Comment 2
Updated by Jim Nelson about 3 years ago
- Status changed from Open to Review
- Assignee changed from Anonymous to Jim Nelson
- Priority set to High
Comment 3
Updated by Jim Nelson about 3 years ago
- Status changed from Review to 5
- Resolution set to fixed
- % Done set to 100
Comment 4
Updated by Charles Lindsay 7 months ago
- Status changed from 5 to Fixed
--- Bug imported by chaz@yorba.org 2013-11-25 21:43 UTC ---
This bug was previously known as bug 1560 at http://redmine.yorba.org/show_bug.cgi?id=1560
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Resolution: RESOLVED FIXED