Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pygobject pygobject
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 303
    • Issues 303
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • pygobjectpygobject
  • Merge requests
  • !160

WIP: Refactor property handling and support more array types

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Sam Spilsbury requested to merge smspillaz/pygobject:properties-refactor-support-array-types into master Dec 29, 2020
  • Overview 2
  • Commits 32
  • Pipelines 2
  • Changes 11

Still WIP, since in d914f991 there is a memory-leak when handling C arrays

This PR is an assortment of various fixes to enable the setting GArray properties with introspected elements correctly in pygobject. One big change is that the set_property codepath is now unified - we always try to use the introspection data first and then fall back to the non-introspection path if that is unavailable.

Some tests which indicated that certain inputs were unsupported have been updated.

Some commits can be safely cherry-picked since they are unrelated to the main work done here. It should be pretty clear which ones those are.

The tests for GArray handling require an update to the Regress object in gobject-introspection!255

Ideas on how to handle the memory leak when unwinding C-array properties welcome.

#37

Might also fix #317 , #23 #14 and #284 , but that needs to be checked.

(And sorry for the long MR. This turned out to be non-trivial, which I guess explains why it went unfixed for so long)

Edited Dec 29, 2020 by Sam Spilsbury
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: properties-refactor-support-array-types