Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pitivi pitivi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 192
    • Issues 192
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • pitivipitivi
  • Merge requests
  • !439

Draft: elements: Fix ctrl+click clears whole selection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thejas Kiran P S requested to merge thejaskiranps/pitivi:selection-fix into master Jun 14, 2022
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

During selection we were checking if the clip belongs to a group or not and pass that single clip or all the clips belonging to its group to timeline.Selection.set_selection(). But while unselecting we creates a temporary GES.Group to hold them. So in the above mentioned 'if case', it got confused as a group created by user and passed all elements inside it to be unselected.

TODO:

  1. Fix test case (test_timeline_timeline.TestGrouping.test_can_group_ungroup)
  2. Write new unittests

Fixes #2433 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: selection-fix