Skip to content

Draft: elements: Fix ctrl+click clears whole selection

Thejas Kiran P S requested to merge thejaskiranps/pitivi:selection-fix into master

During selection we were checking if the clip belongs to a group or not and pass that single clip or all the clips belonging to its group to timeline.Selection.set_selection(). But while unselecting we creates a temporary GES.Group to hold them. So in the above mentioned 'if case', it got confused as a group created by user and passed all elements inside it to be unselected.

TODO:

  1. Fix test case (test_timeline_timeline.TestGrouping.test_can_group_ungroup)
  2. Write new unittests

Fixes #2433 (closed)

Merge request reports