Dragging the viewer leaves the undo stack dirty.
@stefanzzz
Submitted by Stefan-Adrian Popa Assigned to Stefan-Adrian Popa @stefanzzz
Description
Steps to reproduce:
- Add a clip to the timeline.
- Drag the clip in the viewer, making sure the mouse click is released outside the container which holds the viewer.
- Try to do some other operation (like adding a clip).
It won't work and the following error will appear:
Traceback (most recent call last):
File "/home/stefan/workspace/opensource/pitivi-dev/pitivi/pitivi/timeline/timeline.py", line 908, in _drag_drop_cb
toplevel=True):
File "/usr/lib/python3.5/contextlib.py", line 59, in __enter__
return next(self.gen)
File "/home/stefan/workspace/opensource/pitivi-dev/pitivi/pitivi/undo/undo.py", line 190, in started
self.begin(action_group_name, **kwargs)
File "/home/stefan/workspace/opensource/pitivi-dev/pitivi/pitivi/undo/undo.py", line 208, in begin
raise UndoWrongStateError("Toplevel operation started as suboperation", self.stacks)
pitivi.undo.undo.UndoWrongStateError: ('Toplevel operation started as suboperation', [Video position change: [<TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 0 -> 2>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 2 -> 23>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: 0 -> -83>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 23 -> 30>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -83 -> -124>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 30 -> 35>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -124 -> -186>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 35 -> 38>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -186 -> -211>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -211 -> -226>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 38 -> 40>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -226 -> -249>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 40 -> 45>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -249 -> -274>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -274 -> -288>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -288 -> -296>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posx: 45 -> 48>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafb405bca8 (GESVideoUriSource at 0x2c05d10)>.GstFramePositioner::posy: -296 -> -305>, <ClipAdded <GES.UriClip object at 0x7fafa4201a20 (GESUriClip at 0x3b6f990)>>, <TrackElementAdded <GES.UriClip object at 0x7fafa4201a20 (GESUriClip at 0x3b6f990)>, <GES.VideoUriSource object at 0x7fafa4201c60 (GESVideoUriSource at 0x7faf7056ae40)>>, <timeline.KeyframeAddedAction object at 0x7fafa420a1f8 (pitivi+undo+timeline+KeyframeAddedAction at 0x39d1240)>, <timeline.KeyframeAddedAction object at 0x7fafa420a288 (pitivi+undo+timeline+KeyframeAddedAction at 0x3968480)>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafa4201c60 (GESVideoUriSource at 0x7faf7056ae40)>.GstFramePositioner::width: 0 -> 960>, <TrackElementPropertyChanged <GES.VideoUriSource object at 0x7fafa4201c60 (GESVideoUriSource at 0x7faf7056ae40)>.GstFramePositioner::height: 0 -> 400>, <TrackElementAdded <GES.UriClip object at 0x7fafa4201a20 (GESUriClip at 0x3b6f990)>, <GES.AudioUriSource object at 0x7fafa4227708 (GESAudioUriSource at 0x7faf7056a080)>>, <timeline.KeyframeAddedAction object at 0x7fafa4227a20 (pitivi+undo+timeline+KeyframeAddedAction at 0x39d1b60)>, <timeline.KeyframeAddedAction object at 0x7fafa4227ab0 (pitivi+undo+timeline+KeyframeAddedAction at 0x39d1b20)>, <PropertyChanged <GES.UriClip object at 0x7fafa4201a20 (GESUriClip at 0x3b6f990)>.start: 9456838021 -> 4728419010>, <ClipRemoved <GES.UriClip object at 0x7fafa4201a20 (GESUriClip at 0x3b6f990)>>]])