Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
P
pango
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 187
    • Issues 187
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • pango
  • Merge Requests
  • !239

Merged
Opened Sep 14, 2020 by Niklas Gürtler@profclonkContributor

Make dependencies to fontconfig and freetype optional and explicit.

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Similar to !235 (merged), this branch adds meson features for explicitly enabling or disabling the dependencies freetype and fontconfig such that they won't be used even if present on the system.

The meson option use_fontconfig was changed to fontconfig with these possible values:

  • enabled (equivalent to old use_fontconfig=true)
  • auto (equivalent to old use_fontconfig=false)
  • disabled (equivalent to old use_fontconfig=false AND report an error if fontconfig is required on this system).

The behaviour of the old use_fontconfig option is problematic for package managers like conan; with use_fontconfig=false (default), the meson script decides itself whether fontconfig is used or not, and the package manager doesn't really know whether the final built package has it enabled or not. Therefore, I changed it to fontconfig (new name to avoid collisions) with "strong" values enabled/disabled which forcibly enable/disable fontconfig, which will result in an error if it can't be satisfied (e.g. disabled when fontconfig is required on Linux, or enabled on Windows but the library wasn't found) instead of silently ignoring the option.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/pango!239
Source branch: optional-dependencies

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.