RuleInfo class is plain confusing
It looks like it's intended to evaluate an and/or expression (cf this:
enum RulesType {
TYPE__ERR,
AGGREGATE__AND,
AGGREGATE__OR,
MARK_READ,
AUTOCACHE,
AUTODOWNLOAD,
DELETE_ARTICLE
}
However, the __OR
variant is never used, and the __AND
code is used to support a list of rules and it totally ignores the result of applying any rule.
That code looks so wrong that people will want to change it on reading it (see #158 (closed) comments for instance).
This needs to be simplified