Skip to content

Fix window list the second time mouse review gets enabled

Colomban Wendling requested to merge cwendling/orca:mouse-review-multi-activate into master

On initial Wnck calls the signals we connect to get emitted for the initial values, but in case we got disabled and re-enabled we have to get the initial values manually.

This could in theory be avoided by shutting down Wnck when we get disabled, and then the next activation would behave like the initial one, but Wnck.shutdown() is documented as being hacky, and seem too buggy (spews lots of warnings that are not related to our code1).

To test this, assign a key binding to toggle mouse review, enable mouse review, disable it, switch window/workspace, and the re-enable mouse review: it'll be confused and won't present the right windows before you switch window/workspace (or both) again.

1 yes, even clearing the reference to the screen object in the disconnect loop -- which would be needed if we were to actually call Wnck.shutdown() though.

Merge request reports