Skip to content

Don't use invalid indices on empty selection

Michael Weghorn requested to merge michaelweghorn/orca:michaelweghorn/dont_use_invalid_selection_indices_on_empty_selection into master

If the selection is empty, don't try to access items at index 0 and -1.

Seen e.g. with LibreOffice Calc, where this would result in the following warnings being printed with the qt6 UI variant when no cells are selected:

warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: 0
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: -1
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: 0
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: -1
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: 0
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: -1
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: 0
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: -1
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: 0
warn:vcl.qt:247981:247981:vcl/qt6/../qt5/QtAccessibleWidget.cxx:1965: QtAccessibleWidget::selectedItem called with invalid index: -1

(using LibreOffice master as of commit a74017600941 + https://gerrit.libreoffice.org/c/core/+/138750 and related Qt changes on top)

Merge request reports