Redundant OpenQA API calls
The calls to register a new machine and tear it down after the tests are redundant. This is due to the way OpenQA links together Job Groups and Machines. The result is that a "machine" is essentially just a collection of settings which are applied to jobs with that machine type, and it doesn't correspond to an actual physical machine.
This means that this call and the entirety of the teardown_worker.sh
file could potentially be removed without affecting the running of the tests.
I think this would be worth doing as it could cause confusion if someone were to attempt to make changes to settings in the machine registration, only to find that the changes they made appeared to be ignored.
This can be confirmed by checking the MACHINE
setting of any of the tests on openqa.gnome.org, you will see that they all have the value qemu_x86_64 instead of the name of the registered machine which if of the form gitlab-runner-...
.