Skip to content

Improved tab completion in the location entry

James Westman requested to merge jwestman/nautilus:fix-1171 into master

Improves tab completion in the location entry. A GtkEntryCompletion shows a popup when there are multiple matches, so you can choose one or continue typing.

The completion's tree model is populated dynamically as you type using a GFilenameCompleter. Also, when you press Tab and there is not exactly one match to fill in, an error bell is played and the location entry retains focus.

Fixes #1171 (closed).

There are several design issues with this MR as it is. Any feedback is appreciated.

  • The dropdown isn't aligned with the text in the entry because of the folder icon. Maybe this should be fixed in GtkEntryCompletion?
    • Issue filed at gtk#3222
    • Fixed by removing the icon, and by adjusting the xpad of the cell renderer
  • It might look nicer to only show the basenames of the results, rather than the entire path in every row.
    • Addressed by dimming the dirnames so the basenames stand out
  • It would be nice to list all the items in a directory when the path ends in '/'--right now you have to type at least one character to get completions
Edited by James Westman

Merge request reports