Skip to content
  • Carlos Soriano Sánchez's avatar
    batch-rename-dialog: use positions for tag handling · 7fb5aa77
    Carlos Soriano Sánchez authored
    When a tag is added, deleted or moved or a text is changed, inserted
    or deleted, we need to do update the text and tags already present
    based on what changed.
    
    We were checking whether a tag was present or not matching with the
    text rather than deterministically adding, removing or updating the
    positions based on the direct user interaction.
    
    Doing it in this way is a potential problem since two tags added
    writing manually would confuse the underlying handling, apart of being
    harder to have a consistent state of the tags like deleting multiple
    tags at once, deleting tags with text on the sides when selected,
    replacing tags with text, crashes when using overwrite mode instead of
    insertion mode, or crashes when using modifiers. Apart of making the
    handling more complex.
    
    This patch refactors the tag handling for using positions and direct
    manipulation of them instead of text.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771069
    7fb5aa77