• Carlos Soriano Sánchez's avatar
    dnd: use GtkPlacesSidebar drop targets hints · 749a8644
    Carlos Soriano Sánchez authored
    Currently the dnd on the sidebar is only triggered when hovering
    above the sidebar itself. However we would like to give some
    feedback all along on the dnd operation.
    For that GtkPlacesSidebar has set_drop_targets_visible public API,
    which was implemented a few months ago and the GtkFileChooser is
    already using.
    I just forgot to implement the support for it on Nautilus... even if
    the original work was done for Nautilus, since users will probably
    use dnd more on nautilus than on the file chooser.
    I'm not entirely happy with the implementation, since it uses custom
    functions to access the drag data, given that we need them at drag-begin
    time and in random places on the code, since nautilus is doing all the dnd
    work manually and on different places.
    The final result is that drag and drop is still managed mostly on its own
    widgets, in this case list-view and canvas-view, and nautilus-dnd manages
    a central accessor for dnd in nautilus, in this case requesting depending
    on the widget that is the owner of the data, its data through the custom
    functions of that particula widget. All other ways I tried to do it entirely
    with only gtk_drag_* or gdk_drag_* functions were in vanish if no a complete
    refactoring is done, and probably it doesn't worth the effort. Also I
    actually separated the list view dnd code as well, so now at least the
    pattern to handling dnd on nautilus is more or less consistent.
nautilus-dnd.c 24.1 KB