Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,023
    • Issues 1,023
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 132
    • Merge requests 132
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • muttermutter
  • Merge requests
  • !2483

Draft: window: Should not occupy all workspaces when workspaces-only-on-primary

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daniel van Vugt requested to merge vanvugt/mutter:fix-issue-2333 into main Jun 28, 2022
  • Overview 12
  • Commits 1
  • Pipelines 7
  • Changes 1

A window on a secondary monitor with workspaces-only-on-primary is effectively on no workspaces, not all workspaces.

This fixes an infinite loop:

  1. Window too large for primary monitor and is moved to secondary by the constraints logic.
  2. should_be_on_all_workspaces notices the window is on a secondary monitor and so declares it should be on all workspaces.
  3. Being on all workspaces makes the window on the primary monitor because workspaces-only-on-primary is true.
  4. Goto 1.

Closes: #2333

Edited Jul 01, 2022 by Daniel van Vugt
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-issue-2333