Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.2k
    • Issues 1.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !1499

wayland/subsurface: Only show subsurface if parent is mapped

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Robert Mader requested to merge rmader/mutter:issue1384 into master Oct 14, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

The spec states:

A sub-surface becomes mapped, when a non-NULL wl_buffer is applied
and the parent surface is mapped. The order of which one happens
first is irrelevant. A sub-surface is hidden if the parent becomes hidden,
or if a NULL wl_buffer is applied. These rules apply recursively
through the tree of surfaces.

In the past we relied on Clutter actor behaviour to realize the recursive part - which then broke in !664 (merged) when we changed the actor hierachy in regards to subsurfaces.

Explicitly encode the desired behaviour in MetaWaylandSubsurface, fixing the issue and making it future proof.

Closes #1384 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue1384