Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mutter mutter
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.2k
    • Issues 1.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 135
    • Merge requests 135
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • muttermutter
  • Merge requests
  • !110

wayland: Compare geometries after chaining up

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Georges Basile Stavracas Neto requested to merge gbsneto/issue-150 into master May 17, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

After 20176d03, the Wayland backend only synchronizes with the compositor after a geometry was set, and it was different from the current geometry.

That commit was mistakenly comparing the geometry before chaining up, which would yield a false negative on the case where the client wouldn't call set_geometry() before commit().

Fix that by caching the old geometry locally, chain up (and thus apply the new geometry rectangle), then comparing the old and current geometry rectangles.

Fixes #150 (closed)

(This should be cherry-picked to gnome-3-28 too)

Edited May 18, 2018 by Georges Basile Stavracas Neto
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gbsneto/issue-150