Skip to content

pager: draw sticky windows on all workspaces

Matthew Campbell requested to merge lifeisafractal/libwnck:sticky-windows-on-all-workspaces into master

This causes "sticky" windows to draw on all desktops in the pager. This functionality makes way more sense to me than the current behavior (only draw "sticky" widows in the current workspace). I'm open to the conversation if others feel differently and finding a way to get this in with some changes.

One area I'd ask to specifically be reviewed:

  1. I took a look at the window signals connected in wnck_pager_connect_window() and it looks like any case that would require a full pager re-draw due to sticky windows goes through wnck_pager_queue_draw_window() which checks the sticky bit. I'd like someone to double check there isn't another edge case where the full pager needs to be redrawn due to stick window changes.

This was built and tested on my XUbuntu 23.10 system using the xfce4-panel pager plugin (XFCE 4.18.4).

Merge request reports