Skip to content

Fix and enable more compiler warnings

Simon McVittie requested to merge wip/smcv/warnings into master

If we keep this module closer to warnings-clean, then it can be submoduled into Meson projects that enable warnings by default without having to override it to a lower warning-level.

  • console: Mark an unused parameter as such

    This signal handler is only called for SIGWINCH, so it doesn't need to look at its parameter.

  • fdio, xattrs: Mark unused cancellables as such

    These functions take a GCancellable for consistency with other file APIs, but are not actually cancellable at the moment.

  • fdio: Make signedness of iterator consistent with limit

    gcc -Wsign-compare warns about this. The iteration limit is constant and small enough that either int or guint would be fine.

  • fdio: Match signedness of length parameter

    This is documented as taking a length of -1, but the parameter is unsigned, so it's more correctly ((gsize) -1). This silences a warning from gcc -Wsign-compare.

  • tests: Make iterator signedness agree with limit

    g_variant_n_children() returns a size_t (or gsize, which is equivalent) so in principle it could overflow an int, although in practice we are not going to have that many extended attributes. This silences a warning from gcc -Wsign-compare.

  • tests: Make signedness of timestamp agree

    This silences a warning from gcc -Wsign-compare. g_get_monotonic_time() returns a signed int64.

  • meson: Build with more warnings by default

    If we keep this module closer to warnings-clean, then it can be submoduled into Meson projects that enable warnings by default without having to override it to a lower warning-level.

Merge request reports