Build broken in jhbuild
@mcatanzaro
Submitted by Michael Catanzaro Link to original bug (#751919)
Description
I see you updated libgit2 in jhbuild quite recently, but something is still wrong because there are tons of errors when building libgit2-glib:
ggit-submodule.c: In function 'ggit_submodule_set_url':
ggit-submodule.c:212:31: warning: passing argument 1 of 'git_submodule_set_url' from incompatible pointer type [-Wincompatible-pointer-types]
ret = git_submodule_set_url (submodule->submodule,
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:386:51: note: expected 'git_repository * {aka struct git_repository *}' but argument is of type 'git_submodule * {aka struct git_submodule *}'
GIT_EXTERN(int) git_submodule_set_url(git_repository *repo, const char *name, const char *url);
^
ggit-submodule.c:212:8: error: too few arguments to function 'git_submodule_set_url'
ret = git_submodule_set_url (submodule->submodule,
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:386:51: note: declared here
GIT_EXTERN(int) git_submodule_set_url(git_repository *repo, const char *name, const char *url);
^
ggit-submodule.c: In function 'ggit_submodule_set_ignore':
ggit-submodule.c:332:56: warning: passing argument 1 of 'git_submodule_set_ignore' from incompatible pointer type [-Wincompatible-pointer-types]
return (GgitSubmoduleIgnore)git_submodule_set_ignore (submodule->submodule,
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:453:51: note: expected 'git_repository * {aka struct git_repository *}' but argument is of type 'git_submodule * {aka struct git_submodule *}'
ggit-submodule.c:333:56: error: incompatible type for argument 2 of 'git_submodule_set_ignore'
(git_submodule_ignore_t)ignore);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:453:51: note: expected 'const char *' but argument is of type 'enum <anonymous>
'
ggit-submodule.c:332:30: error: too few arguments to function 'git_submodule_set_ignore'
return (GgitSubmoduleIgnore)git_submodule_set_ignore (submodule->submodule,
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:453:51: note: declared here
ggit-submodule.c: In function 'ggit_submodule_set_update':
ggit-submodule.c:372:56: warning: passing argument 1 of 'git_submodule_set_update' from incompatible pointer type [-Wincompatible-pointer-types]
return (GgitSubmoduleUpdate)git_submodule_set_update (submodule->submodule,
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:481:51: note: expected 'git_repository * {aka struct git_repository *}' but argument is of type 'git_submodule * {aka struct git_submodule *}'
ggit-submodule.c:373:56: error: incompatible type for argument 2 of 'git_submodule_set_update'
(git_submodule_update_t)update);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:481:51: note: expected 'const char *' but argument is of type 'enum <anonymous>
'
ggit-submodule.c:372:30: error: too few arguments to function 'git_submodule_set_update'
return (GgitSubmoduleUpdate)git_submodule_set_update (submodule->submodule,
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:481:51: note: declared here
ggit-submodule.c: In function 'ggit_submodule_set_fetch_recurse':
ggit-submodule.c:409:53: warning: passing argument 1 of 'git_submodule_set_fetch_recurse_submodules' from incompatible pointer type [-Wincompatible-pointer-types]
return git_submodule_set_fetch_recurse_submodules (submodule->submodule, fetch_recurse);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:510:51: note: expected 'git_repository * {aka struct git_repository *}' but argument is of type 'git_submodule * {aka struct git_submodule *}'
GIT_EXTERN(int) git_submodule_set_fetch_recurse_submodules(
^
ggit-submodule.c:409:75: warning: passing argument 2 of 'git_submodule_set_fetch_recurse_submodules' makes pointer from integer without a cast [-Wint-conversion]
return git_submodule_set_fetch_recurse_submodules (submodule->submodule, fetch_recurse);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:510:51: note: expected 'const char *' but argument is of type 'gboolean {aka int}'
GIT_EXTERN(int) git_submodule_set_fetch_recurse_submodules(
^
ggit-submodule.c:409:9: error: too few arguments to function 'git_submodule_set_fetch_recurse_submodules'
return git_submodule_set_fetch_recurse_submodules (submodule->submodule, fetch_recurse);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:510:51: note: declared here
GIT_EXTERN(int) git_submodule_set_fetch_recurse_submodules(
^
ggit-submodule.c: In function 'ggit_submodule_get_status':
ggit-submodule.c:519:39: warning: passing argument 2 of 'git_submodule_status' from incompatible pointer type [-Wincompatible-pointer-types]
ret = git_submodule_status (&status, submodule->submodule);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:611:51: note: expected 'git_repository * {aka struct git_repository *}' but argument is of type 'git_submodule * {aka struct git_submodule *}'
ggit-submodule.c:519:8: error: too few arguments to function 'git_submodule_status'
ret = git_submodule_status (&status, submodule->submodule);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2.h:57:0,
from ggit-submodule.h:25,
from ggit-submodule.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/submodule.h:611:51: note: declared here
ggit-submodule.c: In function 'ggit_submodule_set_ignore':
ggit-submodule.c:334:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
ggit-submodule.c: In function 'ggit_submodule_set_update':
ggit-submodule.c:374:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
ggit-submodule.c: In function 'ggit_submodule_set_fetch_recurse':
ggit-submodule.c:410:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1: some warnings being treated as errors
Makefile:759: recipe for target 'ggit-submodule.lo' failed
make[3]: *** [ggit-submodule.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
ggit-remote.c: In function 'ggit_remote_update_tips':
ggit-remote.c:426:32: warning: passing argument 3 of 'git_remote_update_tips' makes integer from pointer without a cast [-Wint-conversion]
message != NULL ? message : "fetch");
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2/clone.h:14:0,
from /home/mcatanzaro/jhbuild/install/include/git2.h:19,
from ggit-remote.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/remote.h:644:51: note: expected 'int' but argument is of type 'const char *'
ggit-remote.c:424:8: error: too few arguments to function 'git_remote_update_tips'
ret = git_remote_update_tips (_ggit_native_get (remote),
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2/clone.h:14:0,
from /home/mcatanzaro/jhbuild/install/include/git2.h:19,
from ggit-remote.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/remote.h:644:51: note: declared here
ggit-remote.c: In function 'ggit_remote_add_fetch_spec':
ggit-remote.c:456:8: error: too few arguments to function 'git_remote_add_fetch'
ret = git_remote_add_fetch (_ggit_native_get (remote), fetch_spec);
^
In file included from /home/mcatanzaro/jhbuild/install/include/git2/clone.h:14:0,
from /home/mcatanzaro/jhbuild/install/include/git2.h:19,
from ggit-remote.c:21:
/home/mcatanzaro/jhbuild/install/include/git2/remote.h:179:51: note: declared here
GIT_EXTERN(int) git_remote_add_fetch(git_repository *repo, const char *remote, const char *refspec);
^
ggit-remote.c: In function 'ggit_remote_set_fetch_specs':
ggit-remote.c:517:8: error: implicit declaration of function 'git_remote_set_fetch_refspecs' [-Werror=implicit-function-declaration]
ret = git_remote_set_fetch_refspecs (_ggit_native_get (remote), &gspecs);
^
ggit-remote.c:517:2: warning: nested extern declaration of 'git_remote_set_fetch_refspecs' [-Wnested-externs]
ret = git_remote_set_fetch_refspecs (_ggit_native_get (remote), &gspecs);
^
ggit-remote.c: In function 'ggit_remote_set_push_specs':
ggit-remote.c:583:8: error: implicit declaration of function 'git_remote_set_push_refspecs' [-Werror=implicit-function-declaration]
ret = git_remote_set_push_refspecs (_ggit_native_get (remote), &gspecs);
^
ggit-remote.c:583:2: warning: nested extern declaration of 'git_remote_set_push_refspecs' [-Wnested-externs]
ret = git_remote_set_push_refspecs (_ggit_native_get (remote), &gspecs);
^
cc1: some warnings being treated as errors
Makefile:759: recipe for target 'ggit-remote.lo' failed
make[3]: *** [ggit-remote.lo] Error 1
ggit-types.c:125:14: error: size of array '_GStaticAssertCompileTimeAssertion_80' is negative
ASSERT_ENUM (GGIT_REMOTE_DOWNLOAD_TAGS_AUTO, GIT_REMOTE_DOWNLOAD_TAGS_AUTO);
^
ggit-types.c:126:14: error: size of array '_GStaticAssertCompileTimeAssertion_81' is negative
ASSERT_ENUM (GGIT_REMOTE_DOWNLOAD_TAGS_NONE, GIT_REMOTE_DOWNLOAD_TAGS_NONE);
^
ggit-types.c:127:14: error: size of array '_GStaticAssertCompileTimeAssertion_82' is negative
ASSERT_ENUM (GGIT_REMOTE_DOWNLOAD_TAGS_ALL, GIT_REMOTE_DOWNLOAD_TAGS_ALL);
^
ggit-types.c:167:100: error: 'GIT_SUBMODULE_IGNORE_RESET' undeclared here (not in a function)
ggit-types.c:190:100: error: 'GIT_SUBMODULE_UPDATE_RESET' undeclared here (not in a function)
ggit-types.c:226:98: error: 'GIT_CHECKOUT_SAFE_CREATE' undeclared here (not in a function)
ggit-types.c:227:14: error: size of array '_GStaticAssertCompileTimeAssertion_162' is negative
ASSERT_ENUM (GGIT_CHECKOUT_FORCE, GIT_CHECKOUT_FORCE);
^
Makefile:759: recipe for target 'ggit-types.lo' failed
make[3]: *** [ggit-types.lo] Error 1
ggit-submodule-update-options.c: In function 'ggit_submodule_update_options_set_remote_callbacks':
ggit-submodule-update-options.c:303:53: error: 'git_submodule_update_options {aka struct git_submodule_update_options}' has no member named 'remote_callbacks'
git_remote_init_callbacks (&options->priv->options.remote_callbacks, GIT_REMOTE_CALLBACKS_VERSION);
^
ggit-submodule-update-options.c:309:25: error: 'git_submodule_update_options {aka struct git_submodule_update_options}' has no member named 'remote_callbacks'
options->priv->options.remote_callbacks = *_ggit_remote_callbacks_get_native (options->priv->remote_callbacks);
^
ggit-submodule-update-options.c: In function 'ggit_submodule_update_options_set_signature':
ggit-submodule-update-options.c:390:25: error: 'git_submodule_update_options {aka struct git_submodule_update_options}' has no member named 'signature'
options->priv->options.signature = NULL;
^
ggit-submodule-update-options.c:396:25: error: 'git_submodule_update_options {aka struct git_submodule_update_options}' has no member named 'signature'
options->priv->options.signature = _ggit_native_get (signature);
^
Version: git master
Resolution: RESOLVED FIXED