libgda-report uses deprecated GdaPixbufData
@murrayc
Submitted by Murray Cumming Assigned to mal..@..db.org
Link to original bug (#757214)
Description
GdkPixbufData is now deprecated. Apparently we should use GResource instead, though I don't know if that can really replace this usage. https://developer.gnome.org/gdk-pixbuf/stable/gdk-pixbuf-Inline-data.html#gdk-pixdata-deserialize
Building with --enable-warnings=fatal (to configure or autogen.sh) shows these helpful warnings (as errors):
rt-parser.c: In function 'rich_text_node_to_docbook': rt-parser.c:1171:3: error: unknown type name 'GdkPixdata' GdkPixdata pixdata; ^ rt-parser.c:1173:7: error: implicit declaration of function 'gdk_pixdata_deserialize' [-Werror=implicit-function-declaration] gdk_pixdata_deserialize (&pixdata, rtnode->binary.binary_length, ^ rt-parser.c:1176:34: error: implicit declaration of function 'gdk_pixbuf_from_pixdata' [-Werror=implicit-function-declaration] pixbuf = gdk_pixbuf_from_pixdata (&pixdata, TRUE, NULL); ^ rt-parser.c:1176:32: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] pixbuf = gdk_pixbuf_from_pixdata (&pixdata, TRUE, NULL); ^ rt-parser.c: In function 'rich_text_node_to_html': rt-parser.c:1383:3: error: unknown type name 'GdkPixdata' GdkPixdata pixdata; ^ rt-parser.c:1388:32: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] pixbuf = gdk_pixbuf_from_pixdata (&pixdata, TRUE, NULL); ^ cc1: all warnings being treated as errors