Skip to content

Fix build on Windows

Tom Schoonjans requested to merge tschoonj/libdazzle:windows-fixes into master

I managed to contribute libdazzle to conda-forge and got the Windows build working, including with the the gobject-introspection bindings.

Several patches were necessary though, which are listed in this MR.

Also, it should be noted that it is currently impossible to build libdazzle with MSVC's cl.exe, due to its liberal use of g_autofree, but it is possible with clang-cl.exe (with some minor patches).

I also saw several warnings related to bitfield conversions such as:

../src/panel/dzl-dock-stack.c(245,15): warning: implicit truncation from 'int' to bit-field changes value from 3 to -1 [-Wbitfield-constant-conversion]
  priv->style = DZL_TAB_BOTH;
              ^ ~~~~~~~~~~~~
../src/panel/dzl-dock-stack.c(246,14): warning: implicit truncation from 'int' to bit-field changes value from 2 to -2 [-Wbitfield-constant-conversion]
  priv->edge = GTK_POS_TOP;
             ^ ~~~~~~~~~~~

These look suspicious and will probably break the execution logic. I will open a separate issue for them.

Merge request reports