"make check" is not run under xvfb
Submitted by Martin Pitt
Link to original bug (#686352)
Description
We have set up jhbuild in Jenkins [1] to be able to eventually do per-commit level testing of GNOME modules (modules themselves and their reverse dependencies once anything changes). Right now quite a lot of the tests fail with errors like
** (check-program:13256): WARNING **: Could not open X display Trace/breakpoint trap (core dumped) FAIL: check-eel
e. g. nautilus, pygobject, or gnome-settings-daemon.
Now, we could fix these modules, and similar failures in the future, but it seems that for a project like GNOME it is not unreasonable to expect that quite a lot of tests need a display server.
From the first look it seems jhbuild would already provide that, as e. g. "jhbuild build --help" says
-x, --no-xvfb run tests in real X and not in Xvfb
which seems to imply that by default it does run xvfb. However, inspecting the code shows that this only happens in jhbuild/modtypes/testmodule.py for LDTP/dogtail tests, not for "make check".
My gut feeling is that it would be easier for everyone if jhbuild ran "make check" under xvfb (unless explicitly disabled), but we can also fix our setup to invoke jhbuild under xvfb-run.
What do you think?
[1] https://jenkins.qa.ubuntu.com/view/Quantal/view/JHBuild%20Gnome/