Skip to content
Snippets Groups Projects

daemon: Use named sockets to avoid network permission requirement

Merged Ondrej Holy requested to merge wip/oholy/runtime-dir-socket into master
All threads resolved!

Use named sockets instead of abstract sockets to avoid network permission requirements for Flatpak applications. Add warnings with hint that --filesystem=xdg-run/gvfsd is needed. Also add session bus fallback for synchronous API. See #515 (closed).

Edited by Ondrej Holy

Merge request reports

Pipeline #237154 passed

Pipeline passed for 90645061 on wip/oholy/runtime-dir-socket

Merged by Ondrej HolyOndrej Holy 4 years ago (Dec 8, 2020 12:02pm UTC)

Merge details

Pipeline #237156 passed

Pipeline passed for 90645061 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Ondrej Holy

      This looks good to me (other than nit above). I can't see how a sync call on a thread would block async calls or anything else on the main thread. However it might be nice to verify that.

  • Ondrej Holy marked this merge request as ready

    marked this merge request as ready

  • Ondrej Holy added 23 commits

    added 23 commits

    • 2da528b6...0524981f - 19 commits from branch master
    • dc27b94e - daemon: Use named sockets to avoid network permission requirement
    • 9aa40b72 - gvfsiconloadable: Fallback to session bus when peer-to-peer fails
    • 80a1bb43 - client: Show warning when peer-to-peer connection failed
    • 39cf4dac - client: Add fallback to session bus also for synchronous API

    Compare with previous version

  • Ondrej Holy resolved all threads

    resolved all threads

  • Ondrej Holy resolved all threads

    resolved all threads

  • Ondrej Holy added 4 commits

    added 4 commits

    • 29a00938 - daemon: Use named sockets to avoid network permission requirement
    • dc0c3356 - gvfsiconloadable: Fallback to session bus when peer-to-peer fails
    • 60ca0cea - client: Show warning when peer-to-peer connection failed
    • 90645061 - client: Add fallback to session bus also for synchronous API

    Compare with previous version

  • Author Maintainer

    I've just added g_dbus_error_strip_remote_error before printing the error message in warnings...

  • merged

  • Please register or sign in to reply
    Loading