Skip to content

trash: Do not fail when G_FILE_COPY_NO_FALLBACK_FOR_MOVE is used

Ondrej Holy requested to merge wip/oholy/trash-performance into master

Restoring files from the trash folder is slow in Nautilus as it attempts to do it recursively. This is because G_IO_ERROR_NOT_SUPPORTED is returned from g_file_move when G_FILE_COPY_NO_FALLBACK_FOR_MOVE flag is used. The error is returned from client-side for pull/push operations after commit 2e765449 as in the most cases the copy-and-delete approach is really used there. But the problem is that it is not in all cases, like in the trash backend case, where the native move operation is used in fact. Let's handle the G_FILE_COPY_NO_FALLBACK_FOR_MOVE flag directly in the backends, but not in the trash backend.

Fixes: nautilus#1589 (closed)

Merge request reports