Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtranslator gtranslator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gtranslatorgtranslator
  • Issues
  • #128

Closed
Open
Created Feb 23, 2021 by Daniel Garcia Moreno@danigmMaintainer

Make all soup_session calls async in `gtr-dl-teams`

We've three calls to the soup_session_send_message in the gtr-dl-teams:

  • https://gitlab.gnome.org/GNOME/gtranslator/-/blob/master/src/gtr-dl-teams.c#L464
  • https://gitlab.gnome.org/GNOME/gtranslator/-/blob/master/src/gtr-dl-teams.c#L196
  • https://gitlab.gnome.org/GNOME/gtranslator/-/blob/master/src/gtr-dl-teams.c#L378

These calls are synchronous so it locks the UI and with a bad connection this could be a problem. We should replace that calls to use the async method soup_session_send_async: https://developer.gnome.org/libsoup/stable/libsoup-client-howto.html#id-1.2.3.6.9

Assignee
Assign to
Time tracking