• Benjamin Otte's avatar
    css: Huge refactoring to avoid computing wrong values · 1454ba15
    Benjamin Otte authored
    Here's the shortest description of the bug I can come up with:
    When computing values, we have 3 kinds of dependencies:
    (1) other properties ("currentColor" or em values)
    (2) inherited properties ("inherit")
    (3) generic things from the theme (@keyframes or @define-color)
    Previously, we passed the GtkStyleContext as an argument, because it
    provided these 3 things using:
    (1) _gtk_style_context_peek_property()
    (2) _gtk_style_context_peek_property(gtk_style_context_get_parent())
    (3) context->priv->cascade
    
    However, this makes it impossible to lookup values other than the ones
    accessible via _gtk_style_context_peek_property(). And this is exactly
    what we are doing in gtk_style_context_update_cache(). So when the cache
    updates encountered case (1), they were looking up the values from the
    wrong style data.
    
    So this large patch essentially does nothing but replace the
    context argument in all compute functions with new arguments for the 3
    cases above:
    (1) values
    (2) parent_values
    (3) provider
    
    We apparently have a lot of computing code.
    1454ba15
Name
Last commit
Last update
build Loading commit data...
demos Loading commit data...
docs Loading commit data...
examples Loading commit data...
gdk Loading commit data...
gtk Loading commit data...
libgail-util Loading commit data...
m4macros Loading commit data...
modules Loading commit data...
perf Loading commit data...
po Loading commit data...
po-properties Loading commit data...
tests Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
ChangeLog.gtk-async-file-chooser Loading commit data...
ChangeLog.gtk-printing Loading commit data...
ChangeLog.pre-1-0 Loading commit data...
ChangeLog.pre-1-2 Loading commit data...
ChangeLog.pre-2-0 Loading commit data...
ChangeLog.pre-2-10 Loading commit data...
ChangeLog.pre-2-12 Loading commit data...
ChangeLog.pre-2-14 Loading commit data...
ChangeLog.pre-2-16 Loading commit data...
ChangeLog.pre-2-2 Loading commit data...
ChangeLog.pre-2-4 Loading commit data...
ChangeLog.pre-2-6 Loading commit data...
ChangeLog.pre-2-8 Loading commit data...
HACKING Loading commit data...
INSTALL.in Loading commit data...
MAINTAINERS Loading commit data...
Makefile.am Loading commit data...
Makefile.decl Loading commit data...
NEWS Loading commit data...
NEWS.pre-1-0 Loading commit data...
README.commits Loading commit data...
README.in Loading commit data...
README.win32 Loading commit data...
acinclude.m4 Loading commit data...
autogen.sh Loading commit data...
config.h.win32.in Loading commit data...
configure.ac Loading commit data...
gail-3.0.pc.in Loading commit data...
gdk-3.0.pc.in Loading commit data...
git.mk Loading commit data...
gtk+-3.0.pc.in Loading commit data...
gtk+-unix-print-3.0.pc.in Loading commit data...
gtk+.doap Loading commit data...
gtk+.spec.in Loading commit data...
gtk-engine-check-abi.sh Loading commit data...
gtk-zip.sh.in Loading commit data...
makecopyright Loading commit data...
makefile.msc Loading commit data...
sanitize-la.sh Loading commit data...
sanity_check Loading commit data...