• Daniel Boles's avatar
    Range: Add should_invert_move() for scrolls & keys · 9b011081
    Daniel Boles authored
    This will be used in subsequent commits to fix the sign by which the
    value is changed in response to directional scroll or keypress events.
    The idea is: you have a movement to make – in the form of a delta that
    follows widget directions, i.e. −1 means left or up, +1 means right or
    down – and you want to know whether that delta needs to be inverted in
    order to produce the intuitively expected directional change of :value.
    The existing should_invert() is not sufficient: it just determines
    whether to invert visually, but we need more nuance than that for input.
    To answer that – while not doubling up the work for scrolls and keys – I
    add a helper should_invert_move(), which considers other relevant state:
     • A parallel movement on priv->orientation should just use the existing
       should_invert(), which already worked OK for this case (not others).
     • Movements on the other orientation now depend on priv->orientation:
        ◦ For a horizontal Range, always invert, so up (i.e. −ve in terms of
          widget coords) always means increase value & vice-versa. This was
          done in get_wheel_delta(), but move it here for use with keys too.
        ◦ For a vertical Range, ignore :invert as it’s only relevant to the
          parallel orientation. Do not care about text direction here either
          as RTL locales do not invert number lines, Cartesian plots, etc.
    This returns TRUE if the delta should be inverted before applying to the
    value, and we can now use this function in both scroll and key handlers.
gtkrange.c 126 KB