Doc Correction Suggestions
Correction Suggestions
method | current | suggestion |
---|---|---|
ListView/get_single_click_activate | "(attributes org.gtk.Method.set_property=single-click-activate)" | "(attributes org.gtk.Method.get_property=single-click-activate)" |
ListBox | "These rows can by dynamically sorted and filtered, and headers can be added dynamically depending on the row content." | "These rows can be dynamically sorted and filtered, and headers can be added dynamically depending on the row content." |
Notebook/get_scrollable | "or.gtk.Method.get_property" | "org.gtk.Method.get_property" |
Overlay | "will be placed a the bottom edge" | "will be placed at the bottom edge" |
Popover/get_offset | "set with [method@Gtk.Popover.set_offset()]" | "set with gtk_popover_set_offset()" [1] |
- [1] erroneous
()
, regretably introduced by one of my commits. As its the first setence, I've reverted it back to its plain text form
Could use a closer look (no action taken)
-
Popover Properties
- Should the doc attributes for Popover:has-arrow and Popover:default-widget use org.gtk.Popover.set as they currently do? Or is that erroneous?
-
Popover API consistency
- While there is Popover/set_default_widget, there is no matching
get_default_widget
. Of course, one could instead useg_object_get_property
with the keydefault-widget
, but its possible the lack of a getter is a oversight.- while trivial, it does require some bindings, like the ones I'm making, to take an additional step to unwrap the GValue to access the underlying default-widget pointer (e.g jgtk:GtkPopover.getDefaultWidget) compared to something like Popover/get_child which does not require the additional step (e.g jgtk:GtkPopover.getChild).
- While there is Popover/set_default_widget, there is no matching