Skip to content

combobox: Avoid extra queue_resize()

Ivan Molodetskikh requested to merge YaLTeR/gtk:unbreak-combobox into main

width-request already ensures it's above the minimum width, so avoid an extra queue_resize() when setting size request to (-1, -1).

This is the same way as GtkDropDown works. This also unbreaks GtkComboBox after the recent allocation fix in 75a417e3.

Incidentally, this also makes GtkComboBox actually resize its popup as intended (that was broken before).

I don't think this is ultimately the final fix, sometimes I still get allocation warnings. But the proper fix will probably involve changing some more allocation machinery around popovers. This is good enough for now.

Fixes #5644 (closed).

cc @matthiasc @otte

Merge request reports