Skip to content

gtkimcontextwayland: Shuffle full resets after IM changes

Carlos Garnacho requested to merge wip/carlosg/shuffle-reset-take2 into main

Doing reset() on the text widgets after commit and delete_surrounding is still too eager for some IMs (e.g. those that expect being able to commit text while keeping a preedit buffer shown).

However, reset() is more of a "synchronize state" action on Wayland, and it is still desirable to do that after changes that do come from the IM (e.g. requesting the new surrounding text and cursor/anchor positions). Notably here, the text_input protocol may still come up with a preedit string after this state synchronization happens.

Shuffle the code so that the text widgets do not reset() the IM context after text is deleted or committed, but the Wayland IM does apply its practical effects after these actions happen. This keeps the Wayland IM fully up-to-date wrt text widget state, while not altering the ::commit and ::delete-surrounding-text behavior for other IM context implementations.

Closes: #5200 (closed) Fixes: 5b78fe27 (gtktextview: Also reset IM context after IM...) Fixes: 7c0a395f (gtktext: Also reset IM context after IM...) Fixes: 52ac71b9 (gtktextview: Shuffle the places doing IM reset) Fixes: 9e29739e (gtktext: Shuffle the places doing IM reset)

Merge request reports