Skip to content
GitLab

Remove the pack-type child property from GtkBox

Closed Timm Bäder requested to merge wip/baedert/box2 into master

The pack-type child property in GtkBox was holding back on using GtkWidget's own child list properly. The ordering rules wrt the different pack-type values was confusing.

This MR:

  • Removes the pack-type child property from GtkBox
  • Removes priv->children from GtkBox and simply makes it use the children list every widget has nowadays. This makes adding a widget to a GtkBox O(1) again. We still have to fiddle with css nodes in gtkbox.c a bit though.
  • Removes gtk_box_pack_start and gtk_box_pack_end, leaving gtk_container_add as the way of adding a widget to a GtkBox
  • Fixes up all the (composite) widgets to retain the old widget order, etc.

Merge request reports