Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,607
    • Issues 1,607
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 221
    • Merge requests 221
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !4625

gtkplacessidebar: Fix crash when remove or rename bookmark

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Corey Berla requested to merge coreyberla/gtk:gtkplacessidebar into main Apr 06, 2022
  • Overview 7
  • Commits 1
  • Pipelines 6
  • Changes 1

When a bookmark is removed or renamed, the row is removed automatically via a call to the update_places function. Since the popovers are children of the row, it crashes. Set the popovers to have sidebar as parent before, so they can be reused and not crash.

I have a duplicate merge request for Nautilus since it is using the same code nautilus!816 (merged)

Edited May 07, 2022 by António Fernandes
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gtkplacessidebar