Skip to content

popover: Unrealize upon hiding

Ivan Molodetskikh requested to merge YaLTeR/gtk:fix-popover-fps-fluctuation into main

When the popover first opens it creates itself a surface which shares the frame clock with the parent surface and inhibits its freeze. Before this patch, when the popover was closed, its surface remained alive, along with its frame clock freeze inhibit. This caused random FPS drops on the parent surface.

This patch makes the popover unrealize upon closing, thus dropping the frame clock freeze inhibit and fixing the FPS fluctuation.

Closes #4246 (closed)

I'm not sure if gtk_widget_unrealize () in hide () is allowed, but everything seems to work fine.

Merge request reports