Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.6k
    • Issues 1.6k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 240
    • Merge requests 240
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !435

filechoosernative: Implement gtk_file_chooser_set_filter()

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Michael Catanzaro requested to merge mcatanzaro/#1492 into gtk-3-24 Nov 29, 2018
  • Overview 4
  • Commits 3
  • Pipelines 4
  • Changes 2

gtk_file_chooser_set_filter() doesn't work for GtkFileChooserNative

The code forwards added and removed filters to the delegate dialog, but doesn't do anything to set the selected one, so the wrong one gets chosen. So let's do that.

This merge request includes two separate fixes: one to fix the fallback dialog, and one to fix the portal dialog. The fix for the portal dialog depends on these two pull requests:

  • https://github.com/flatpak/xdg-desktop-portal/pull/286
  • https://github.com/flatpak/xdg-desktop-portal-gtk/pull/173

Fixes #1492 (closed)

Edited Jan 16, 2019 by Michael Catanzaro
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mcatanzaro/#1492