Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,540
    • Issues 1,540
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 227
    • Merge requests 227
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !283

listbox: Unparent child after removing from sequence

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Georges Basile Stavracas Neto requested to merge gbsneto/issue-1258 into master Aug 02, 2018
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 1

Unparenting a GtkListBoxRow can drop its last reference, which will free its memory. Right after unparenting, though, we were accessing the row's iter - which assumes that the row is still alive. This causes a crash when, for example, binding two or more models to the listbox.

Fix that by unparenting after removing the row from the internal GSequence. This is the last place in the function that was trying to access any field from the row.

Fixes #1258 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gbsneto/issue-1258