Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.6k
    • Issues 1.6k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 239
    • Merge requests 239
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !2191

wayland: Update to xdg-decoration protocol

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Isaac Freund requested to merge ifreund/gtk:xdg-deco into gtk-3-24 Jul 04, 2020
  • Overview 52
  • Commits 1
  • Pipelines 4
  • Changes 11

Currently gtk uses the out of date and non-standardized server-decoration protocol from kde. This commit replaces the implementation of this old server-decoration protocol with an implementation of the xdg-decoration protocol standardized in the wayland-protocols repository.

The new protocol allows us to specify a preference, and so we always ask for CSD and initially enable CSD, only switching to SSD if the server disregards our preference.

Notable changes include:

  • A new GDK window state for SSD.

  • Deprecation of gdk_wayland_display_prefers_ssd(). The new protocol doesn't provide global state, so this function is deprecated and always returns false.

  • Renaming of gdk_wayland_window_announce_csd/ssd() to gdk_wayland_window_request_csd/ssd(). The semantics have changed with the new protocol and the old names are not merely wrong but misleading.

If this patch looks good, I'd be happy to send an MR for the master branch as well.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xdg-deco