Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,607
    • Issues 1,607
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 221
    • Merge requests 221
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !1771
The source project of this merge request has been removed.

Resolve "Use-after-free crash in `thaw_updates()`"

Merged Peter Bloomfield requested to merge (removed):2657-avoid-use-after-free-suggestion into master Apr 26, 2020
  • Overview 0
  • Pipelines 0
  • Changes 1

file-system-model: Avoid use-after free

This is a possible fix for https://gitlab.gnome.org/GNOME/gtk/-/issues/2657

Use a NULL return from g_file_query_info_finish() to detect cancellation
of the query, and avoid derferencing a stale pointer.

file-system-model: Refactor a helper

Push more common code into the helper for
gtk_file_system_model_query_done() and
gtk_file_system_model_one_query_done().

Closes #2657

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2657-avoid-use-after-free-suggestion