Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,605
    • Issues 1,605
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 219
    • Merge requests 219
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !122

WIP: Entry: Make STATE_FLAG_PRELIGHT/:hover work

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daniel Boles requested to merge wip/dboles/entry-hover into gtk-3-22 Apr 20, 2018
  • Overview 15
  • Commits 2
  • Pipelines 4
  • Changes 2

[ This is WIP because:

  • I don't know if anyone with influence cares enough about this to want it in GTK+ 3
  • If they want it, the current implementation probably breaks stuff, so it would need
    • testing to (probably) prove or disprove that
    • if proving it, a direction on how to proceed instead (e.g. add a whole-widget window) ]

We were only detecting prelight on the icons but not the rest of the Entry. This commit resolves that by renaming priv->text_area to priv->event_window, extending it to cover the entire widget, replacing previous uses of text_area’s allocation with priv->text_allocation, and making ::(enter|leave)-notify detect hovering and update our StateFlags.

#196 (closed)

Edited Apr 30, 2018 by Daniel Boles
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/dboles/entry-hover